Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic.deprecated precedence with other "diagnostic.*" settings #10080

Closed
RoloEdits opened this issue Apr 1, 2024 · 0 comments · Fixed by #10084
Closed

diagnostic.deprecated precedence with other "diagnostic.*" settings #10080

RoloEdits opened this issue Apr 1, 2024 · 0 comments · Fixed by #10084
Labels
C-enhancement Category: Improvements

Comments

@RoloEdits
Copy link
Contributor

The current implimentation seems to take the other diagnostic options, for example diagnostic.warn, as a priority and removes any effect the diagnostic.deprecated would have:

conflicting_helix_diagnostic_visuals

I think having a priority of errors and warns first is good, but for situations where the kind of modifiers don't overlap, such as curl on warn and a strikethrough on deprecated, the effects could just blend together. Where they overlap in a modifier, the current behavior is fine. And I have not tested or looked, but the deprecated option seems like it should be prioritized before info, which it may already do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant