Diagnostic picker doesn't show diagnostics if the filepath for the current file contains a '+'

[JuliusBrueggemann]

Summary

If a filepath contains a '+' character, the diagnostic picker will not display diagnostics in that file. The workspace diagnostic picker is unaffected by this. Presumably, other "special" character might also affect the diagnostic picker, even though I did not test with any other characters.

Reproduction Steps

Create the file main.cpp with the following content in a directory called c++ (like ~/c++/main.cpp). clangd will correctly issue a diagnostic for this error (that Helix correctly displays):

However, when opening the diagnostic picker with Space + d, the diagnostic does not appear:

On the other hand, the workspace diagnostic picker (Space + D) does show the diagnostic:

If main.cpp is instead placed in a directory whose path does not contain "special" characters like '+', the diagnostic picker works as expected:

Helix log

No response

Platform

Linux

Terminal Emulator

GNOME Terminal 3.48.1 using VTE 0.72.2 +BIDI +GNUTLS +ICU +SYSTEMD (This is the output from gnome-terminal --version)

Helix Version

helix 23.05 (7f5940b)

[the-mikedavis]

I can reproduce this with clangd but not rust-analyzer. clangd percent-encodes the +s, so the diagnostics come in with a URI like file:///tmp/%2B/main.cpp rather than file:///tmp/+/main.cpp. The document diagnostics picker looks up the diagnostics using a URL it derives from the file path and we don't percent-encode the +.

helix/helix-term/src/commands/lsp.rs

Lines 514 to 520 in 18e07ad

	if let Some(current_url) = doc.url() {
	let diagnostics = cx
	.editor
	.diagnostics
	.get(&current_url)
	.cloned()
	.unwrap_or_default();

I believe we need to normalize the Urls in the diagnostics field on Editor (https://datatracker.ietf.org/doc/html/rfc3986#section-6.2.2.2), so this looks like another instance of #3267

[pascalkuthe]

I don't think normalizing is quite enough. We actually need to convert the URLs to paths and cannonicolize them (see #3347 (comment)). Diagnostics are the only thing we store as URLs instead of paths (even though the LS alwayr sends URLs)