fix: lsp: Sort edits by start range, Omnisharp sends them in reverse

helix-editor · Jun 2, 2022 · 3d91c99 · 3d91c99
1 parent 99e08f5
commit 3d91c99
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/helix-lsp/src/lib.rs b/helix-lsp/src/lib.rs
@@ -173,9 +173,13 @@ pub mod util {
 
     pub fn generate_transaction_from_edits(
         doc: &Rope,
-        edits: Vec<lsp::TextEdit>,
+        mut edits: Vec<lsp::TextEdit>,
         offset_encoding: OffsetEncoding,
     ) -> Transaction {
+        // Sort edits by start range, since some LSPs (Omnisharp) send them
+        // in reverse order.
+        edits.sort_unstable_by_key(|edit| edit.range.start);
+
         Transaction::change(
             doc,
             edits.into_iter().map(|edit| {