-
Notifications
You must be signed in to change notification settings - Fork 253
Bump outbound gossip connections to 6 for seed nodes #1507
base: master
Are you sure you want to change the base?
Conversation
@jadeallenx This PR is mostly outdated after the merge of #1541, except for the change in outbound connections of seed.config vs sys.config. Can this PR be freshened up? |
1e4c8db
to
e7182b0
Compare
why so low for seed nodes? 4000 in and 6 out seems like a gossip vacuum rather than seeder |
Actually per https://github.com/helium/blockchain-core/blob/master/src/blockchain_sup.erl#L103-L104 the outbound_gossip_connections should be 18 if max_inbound is 6 right? |
Inbound is 4000, so outbound 6000 by that working lol |
why yes it would be.. |
We talked this over and the inbound number is so high because it needs to be high to handle the load for ARP requests which is the seed nodes primary function. The outbound number is really about outbound gossip and it's fine at this level. So we're going to leave it as-is in this PR. |
No description provided.