This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
move autogen grpc code into proto dep #1490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgrunewald
commented
Mar 17, 2022
rebar.config
Outdated
| @@ -40,7 +41,7 @@ | |||
| ]}. | |||
|
|
|||
| {plugins, [ | |||
| {grpcbox_plugin, {git, "https://github.com/andymck/grpcbox_plugin.git", {branch, "andymck/ts-master"}}}, | |||
| {grpcbox_plugin, {git, "https://github.com/andymck/grpcbox_plugin.git", {branch, "andymck/ts-master/combined-opts-and-template-changes"}}}, | |||
There was a problem hiding this comment.
i'm not clear if this is even necessary anymore or if there's anything else that might be using it.
There was a problem hiding this comment.
I've wondered about this.. did you try removing it?
There was a problem hiding this comment.
grpcbox plugin is only used to generate the grpc PB files. If that has all moved out of miner then this is not required
|
if we move in this direction, this should be updated to point to the proto repo's master branch before merging |
jwmakesgames
approved these changes
May 16, 2022
jeffgrunewald
force-pushed
the
jg/move_grpc_client_to_proto
branch
from
afc9181 to
ce54416
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to consume grpc client modules as application dependencies instead of using the grpcbox plugin to (re)generate them on the fly with each new application build regardless of whether or not the module definitions have changed upstream.