-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vladistone patch 1: Update user-guide.adoc (images & TOC & :sectnumlevels: up to 3) #819
Conversation
added the navigation links for Mapping panel
Hi @Vladistone. Thanks for this big PR! I really appreciate you updated all these screenshots and the thought you have put into making these user guide modifications. Must have been much work. That said, I have a list of comments:
Some things I really like:
For the next time, it would be good if we could talk about the changes beforehand (before you actually make them). That would save you and me some work. Also, it would be better to make the PRs step by step. One huge PR is much less likely to be completely accepted than many small PRs. I would suggest that we do this step by step if you have the time. One type of change, one PR. |
Hi @helgoboss, this is my first attemption on this site and even more so with ASCIIdoc in principle! therefore, I was not familiar with the procedures for processing changes and introducing them into the master code. So I take all your critics and am ready to fix the errors. Further - I answer on the points of comments:
I had to choose the second option.
Please give me idea to do it to another way... |
Hi @Vladistone!
Okay, I will try to identify the source of this error and fix it. We should wait with the screenshot stuff until this is fixed.
At some point, I will go through the screenshots step by step and mark them accordingly. Repeated screenshots must be avoided, this should be solved using cross references to those images.
In the process of marking the screenshots, I can also fix the spelling.
AsciiDoc has a feature named Book Parts (when using
GitHub limits the AsciiDoc features, that's correct. I'm not even sure if it supports doctype book, must try it. Breadcrumbs are something that I don't want to add manually. It's not just about writing them once, it's about maintaining them. This should definitely be a responsibility of the renderer of the AsciiDoc document. The official AsciiDoc docs also don't add breadcrumbs manually. In our case, the renderer is GitHub and it doesn't generate any breadcrumbs, nothing we can do about it. So the only option would be to change the renderer, generating a HTML document or even a lower-level AsciiDoc document ourselves, as part of the ReaLearn build process. Let's skip breadcrumbs for now. It's a topic for another day.
I'm not sure I understand that. What's wrong with creating an image that contains arrows or numbers to name the specific parts? Something else: You have created another PR and now all screenshots are SVGs (instead of PNGs). And the number of changes is very high. That's unfortunately nothing I can merge. Really, we need to do it step by step, small PRs that do one thing only, and talk about it before actually doing it. Otherwise you put so much work into it and I have to say "no", which makes both of us feel bad ;) |
Hi @helgoboss! |
Multiple minor changes in:
** basics;
** Reference (part 1) for Main panel;
** Reference (part 2) for Mapping panel;
Added:
This was a compromise between continuous chapter numbering and a deeper level of table of contents numbering up to 3 (rather than level 5 - what was be easy for you and me ealry moment). This made it possible not to clutter up the description and table of contents with a digital hierarchy. But at the same time - should to hepl for facilitate navigation through the sections of that serios manual (especially in the monotonous detail of the "Reference".