Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to provide core package without content / scripts #128

Open
markusbaumgartltdmsystems opened this issue Jun 19, 2023 · 8 comments
Open

Comments

@markusbaumgartltdmsystems

We are using swagger-net for some of our ASP.NET Framework projects within our company and where very happy to find an "up-to-date" alternative to Swashbuckle!
Actually we have a request to provide similar division of released NuGet packages:

  • one "Core" package only containing the Swagger.Net.dll along with licenses.txt etc
  • and one package as it is now with content / scripts
    We are used to add / configure swagger within another file/structure
    rather than "SwaggerConfig.cs".

Many thanks in advance if that would be possible!

Note: For internal purpose I re-arranged the contents of the original package like shown in attached screenshot. (Although I did not put license etc)
2023-06-19_10-17-42

@heldersepu
Copy link
Owner

This is a lot of work ... lately I rarely make any big changes to this project
What are the benefits of this?

@heldersepu
Copy link
Owner

image

Looking at the contents of the package:
https://nuget.info/packages/Swagger-Net/8.4.19.1
The only file of actual weight is the dll with 3.8MB everything else is tiny

@markusbaumgartltdmsystems
Copy link
Author

Hey there!
What I meant is actually to just split-off in two packages.
The assemblies (lib/net45/*) and package dependencies will be moved to a mentioned Swagger-Net.Core package.
The existing one will have only one dependency to the Swagger-Net.Core and still ship along all the other contents of the package (Content/Tools...).
It should be basically to define an additional nuspec file.
I will see if I can prepare that as sample for you.

BR

@heldersepu
Copy link
Owner

@markusbaumgartltdmsystems
You still haven't answered my question ....
What are the benefits of this? Why do this?

I really don't want to publish another package

@heldersepu
Copy link
Owner

heldersepu commented Jul 6, 2023

The Content and Tools are tiny files ...
it is just to add some default config ("SwaggerConfig.cs") if not already present

you can read more about that code:
https://github.com/heldersepu/Swagger-Net/blob/master/Swagger.Net/Nuget/Tools/Init.ps1

You could add an additional condition there to skip the move if it detects the other file/structure you are using

@markusbaumgartltdmsystems
Copy link
Author

it is just to add some default config ("SwaggerConfig.cs") if not already present

That is what I actually do not want and submitted this request.
I do the swagger integration along within my own file structure.

@heldersepu
Copy link
Owner

In that case it will be best to modify the init.ps1 to skip the move when it detects your structure

@heldersepu
Copy link
Owner

Would be best if you followed the standard ... but adding an exception in that PowerShell script is very simple, send a PR for that and I will review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants