Skip to content

fix(server): portable exit-code on subprocess-alive=false path (windows build break) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marksverdhei merged 1 commit into from
Jun 4, 2026
Merged

fix(server): portable exit-code on subprocess-alive=false path (windows build break) #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tools/server/server-models.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,15 @@ void server_models::load(const std::string & name) {
// but that cleanup can stall on log_thread.join() if the stdout pipe isn't
// EOFing (e.g. another process inherited the write end). Setting status here
// breaks the "500 forever" loop even when the management thread is stuck.
this->update_status(name, SERVER_MODEL_STATUS_UNLOADED, child_proc->return_status);
//
// subprocess_join() is the portable way to read the exit code —
// subprocess_s::return_status exists only on POSIX (the Windows variant uses
// hProcess + GetExitCodeProcess via subprocess_join). subprocess_alive()
// already reaped the zombie on POSIX, so subprocess_join() returns
// immediately with the cached status.
int child_exit = 0;
subprocess_join(child_proc.get(), &child_exit);
this->update_status(name, SERVER_MODEL_STATUS_UNLOADED, child_exit);
// Force the stdout pipe read end closed so log_thread's fgets() returns and
// the outer thread can proceed past log_thread.join().
if (child_proc->stdout_file) {
Expand Down
Loading