Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] mafft function #2

Open
Andreas-Bio opened this issue Jun 29, 2017 · 2 comments
Open

[request] mafft function #2

Andreas-Bio opened this issue Jun 29, 2017 · 2 comments

Comments

@Andreas-Bio
Copy link

Andreas-Bio commented Jun 29, 2017

Are you still maintaining the CRAN version?

Can you please add the option to mafft to add options freely?
I really need the --unalignlevel --allowshift --keeplength options, but I have to fix() it every time.

@FranzKrah
Copy link
Collaborator

If you already coded the solution, please just mail to us, then we can include.
Cheers, Franz

@Andreas-Bio
Copy link
Author

Andreas-Bio commented Jul 5, 2018

I just removed this part from the function:

else {
    options <- match.arg(options, c("--adjustdirection", 
                                    "--adjustdirectionaccurately"))
    options <- paste(options, collapse = " ")
}

Which enables me to pass options via the option parameter of the function like this: options= "--thread 4 --adjustdirection --nwildcard"

This may be less user friendly because it will not catch spelling errors in, for example --adjustdirectionaccurately, however it will give more experienced users more flexibility. Then again it's not that bad, because if mafft is supplied with a mispelled parameter it crashes instantly.

This is just my personal opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants