Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 update grammars on main #5234

Open
Felienne opened this issue Mar 9, 2024 · 0 comments
Open

🧹 update grammars on main #5234

Felienne opened this issue Mar 9, 2024 · 0 comments

Comments

@Felienne
Copy link
Member

Felienne commented Mar 9, 2024

This one is a bit similar to #5233 (also fixed recently in #5227)

If keywords are translated, they don't automatically move to the grammars, there is a script for that:

python content/yaml_to_lark_utils.py

When the tests run, this script executed, so the tests always work with the latest grammars:

https://github.com/hedyorg/hedy/blob/main/build-tools/github/validate-tests

But these changes are not committed to main, such that the changes to the grammars are not persistent until someone commits them, also leading to problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant