Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http2 #85

Open
cyberbudy opened this issue Jun 19, 2024 · 1 comment
Open

Http2 #85

cyberbudy opened this issue Jun 19, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cyberbudy
Copy link

Thanks for a great project

I have a question about your usage of httpx client. As I understand from FCM documentation, after upgrading to HTTPv1 API the recommended way to send batch messages is to use multiplexing via HTTP/2 protocol.
To use it with httpx you need to install httpx[http2] and pass http2 flag to client

httpx.AsyncClient(http2=True)

otherwise it establishes connection with HTTP1.1(now it works such way)

So, my question is it was a design choice not to use http2(for some reasons) or just missed?

@ndmytro
Copy link
Collaborator

ndmytro commented Jun 22, 2024

Thank you for your kind words about the project.

Regarding your question about the usage of the httpx client, at the time we started the project, HTTP/1.1 met our requirements and fit the plans we had in place. We did not initially incorporate HTTP/2, and we appreciate you bringing this to our attention.

We will certainly look into updating the implementation to utilize HTTP/2 as per the recommended approach for sending batch messages via the HTTPv1 API. Additionally, we always welcome contributions, so if you're interested in helping with this update or any other aspect of the project, it would be greatly appreciated.

@ndmytro ndmytro added enhancement New feature or request help wanted Extra attention is needed labels Jun 22, 2024
@cyberbudy cyberbudy mentioned this issue Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Development

No branches or pull requests

2 participants