add ZECTEST, fix LTC/LTCTEST #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meherett
requested changes
Jul 23, 2021
Comment on lines
+3216
to
+3225
| "P2PKH": 0x488ade4, | ||
| "P2SH": 0x488ade4, | ||
| "P2WPKH": None, | ||
| "P2WPKH_IN_P2SH": None, | ||
| "P2WSH": None, | ||
| "P2WSH_IN_P2SH": None | ||
| }) | ||
| EXTENDED_PUBLIC_KEY = ExtendedPublicKey({ | ||
| "P2PKH": 0x019da462, | ||
| "P2SH": 0x019da462, | ||
| "P2WPKH": 0x04b24746, | ||
| "P2WPKH_IN_P2SH": 0x01b26ef6, | ||
| "P2PKH": 0x488b21e, | ||
| "P2SH": 0x488b21e, |
Collaborator
There was a problem hiding this comment.
It works in both P2PKH and P2SH but the standard of Litecoin EPrivateKey is 0x019d9cfe and EPublicKey is 0x019da462.
Collaborator
There was a problem hiding this comment.
Use this on LitecoinMainnet
EXTENDED_PRIVATE_KEY = ExtendedPrivateKey({
"P2PKH": 0x019d9cfe, # 0x488ade4
"P2SH": 0x019d9cfe, # 0x488ade4
"P2WPKH": None,
"P2WPKH_IN_P2SH": None,
"P2WSH": None,
"P2WSH_IN_P2SH": None
})
EXTENDED_PUBLIC_KEY = ExtendedPublicKey({
"P2PKH": 0x019da462, # 0x488b21e
"P2SH": 0x019da462, # 0x488b21e
"P2WPKH": None,
"P2WPKH_IN_P2SH": None,
"P2WSH": None,
"P2WSH_IN_P2SH": None
})
Contributor
Author
There was a problem hiding this comment.
Got the data by the ltc chainparams.
https://github.com/litecoin-project/litecoin/blob/master/src/chainparams.cpp#L132
Collaborator
There was a problem hiding this comment.
Okay, Maybe I will include option to access both extends keys next time. Good Job :)
meherett
added a commit
that referenced
this pull request
Nov 26, 2024
add ZECTEST, fix LTC/LTCTEST Changed -> Litecoin (LTC) mainnet extend private key from `0x019d9cfe` to `0x488ade4` and public key from `0x019da462` to `0x488b21e` prefixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.