Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/aligned dynamic table #551

Merged
merged 19 commits into from
Apr 13, 2021
Merged

Add/aligned dynamic table #551

merged 19 commits into from
Apr 13, 2021

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Apr 5, 2021

Motivation

Add support for new AlignedDynamicTable type originally developed as part of ndx-icephys-meta to hdmf.common

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel requested review from rly and ajtritt April 5, 2021 02:54
src/hdmf/common/table.py Outdated Show resolved Hide resolved
@oruebel oruebel marked this pull request as ready for review April 9, 2021 06:22
@oruebel
Copy link
Contributor Author

oruebel commented Apr 13, 2021

@rly @ajtritt this PR is ready for review

ajtritt
ajtritt previously approved these changes Apr 13, 2021
@oruebel
Copy link
Contributor Author

oruebel commented Apr 13, 2021

@ajtritt can you re-approve. There was a merge conflict on the CHANGELOG that blocked merging

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #551 (09ce741) into dev (4e32a9f) will increase coverage by 0.22%.
The diff coverage is 98.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #551      +/-   ##
==========================================
+ Coverage   85.22%   85.45%   +0.22%     
==========================================
  Files          39       41       +2     
  Lines        8082     8209     +127     
  Branches     1728     1764      +36     
==========================================
+ Hits         6888     7015     +127     
+ Misses        842      841       -1     
- Partials      352      353       +1     
Impacted Files Coverage Δ
src/hdmf/common/table.py 83.53% <ø> (ø)
src/hdmf/common/alignedtable.py 98.27% <98.27%> (ø)
src/hdmf/common/__init__.py 74.16% <100.00%> (+0.43%) ⬆️
src/hdmf/common/io/__init__.py 100.00% <100.00%> (ø)
src/hdmf/common/io/alignedtable.py 100.00% <100.00%> (ø)
src/hdmf/build/objectmapper.py 91.87% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e32a9f...09ce741. Read the comment docs.

@oruebel oruebel merged commit cfd1c79 into dev Apr 13, 2021
@oruebel oruebel deleted the add/aligned_dynamic_table branch April 13, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants