Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Expose aws_region to HDF5IO #1039

Closed
CodyCBakerPhD opened this issue Jan 25, 2024 · 1 comment · Fixed by #1040
Closed

[Bug]: Expose aws_region to HDF5IO #1039

CodyCBakerPhD opened this issue Jan 25, 2024 · 1 comment · Fixed by #1040
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)

Comments

@CodyCBakerPhD
Copy link
Contributor

What happened?

While establishing benchmarks for various streaming methods, I ran into an error I hadn't observed in the past, Point of termination is https://github.com/h5py/h5py/blob/6b512e5edf80f6660e0f07c704ab59faa733008b/h5py/_hl/files.py#L507

Since older versions of h5py don't necessarily run into this, one argument is that ros3 is only supported under those older versions

But it's also only one extra kwarg so easy to pass along

Steps to Reproduce

import pynwb

s3_url = "s3://dandiarchive/blobs/8c5/65f/8c565f28-e5fc-43fe-8fb7-318ad2081319"
io = pynwb.NWBHDF5IO(path=s3_url, mode="r", load_namespaces=True, driver="ros3")
nwbfile = io.read()
acquisition_path = "ElectricalSeriesAp"
slice_range = (slice(0, 30_000), slice(0, 384))  # ~23 MB
nwbfile.acquisition[acquisition_path].data[slice_range]

Traceback

No response

Operating System

Windows

Python Executable

Conda

Python Version

3.11

Package Versions

No response

@CodyCBakerPhD
Copy link
Contributor Author

#1040 shows how to resolve but does not go the extra mile to properly expose it to the outer level. Probably a follow-up PR on pynwb to expose it there too

@rly rly added category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) labels Apr 11, 2024
@rly rly closed this as completed in #1040 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants