Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: NWBZarrIO should have load_namespaces=True by default #198

Closed
3 tasks done
rly opened this issue Jun 3, 2024 · 2 comments · Fixed by #204
Closed
3 tasks done

[Feature]: NWBZarrIO should have load_namespaces=True by default #198

rly opened this issue Jun 3, 2024 · 2 comments · Fixed by #204
Assignees
Labels
category: enhancement improvements of code or code behavior

Comments

@rly
Copy link
Contributor

rly commented Jun 3, 2024

What would you like to see added to HDMF-ZARR?

Following this change in PyNWB NeurodataWithoutBorders/pynwb#1748

Is your feature request related to a problem?

No response

What solution would you like?

Consistency between NWBHDF5IO and NWBZarrIO

Do you have any interest in helping implement the feature?

No.

Code of Conduct

@rly rly added the category: enhancement improvements of code or code behavior label Jun 3, 2024
@rly rly added this to the Next Major Release: 1.0.0 milestone Jun 3, 2024
@mavaylon1
Copy link
Contributor

mavaylon1 commented Jun 6, 2024

I'll take a look next week.

@mavaylon1
Copy link
Contributor

mavaylon1 commented Jul 8, 2024

Context: We want to have load_namespaces to be True by default. This reads cached schemas and automatically tries to generate the API for any missing namespaces. The prime example being extensions.

On the pynwb side, I do not see any tests involving a roundtrip for a file with extensions, testing the whole load_namespace finding the cached schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants