Skip to content

Commit 732791d

Browse files
committed
Fail fast if parameters are incorrect !
1 parent 2790592 commit 732791d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

tcp/tcp-linux.cc

+6
Original file line numberDiff line numberDiff line change
@@ -782,6 +782,7 @@ int LinuxTcpAgent::command(int argc, const char*const* argv)
782782
printf("%s %s %s\n", argv[0], argv[1], argv[2]);
783783
if (install_congestion_control(argv[2])==FALSE) {
784784
printf("Error: do not find %s as a congestion control algorithm\n", argv[2]);
785+
exit(-5);
785786
cong_ops_manager.dump();
786787
}
787788
return (TCL_OK);
@@ -790,6 +791,7 @@ int LinuxTcpAgent::command(int argc, const char*const* argv)
790791
printf("%s %s %s %s %s\n", argv[0], argv[1], argv[2], argv[3], argv[4]);
791792
if (!paramManager.set_param(argv[2], argv[3], atoi(argv[4]))) {
792793
printf("Error: do not find %s as a parameter for congestion control algorithm %s\n", argv[3], argv[2]);
794+
exit(-5);
793795
};
794796
return (TCL_OK);
795797
};
@@ -798,6 +800,7 @@ int LinuxTcpAgent::command(int argc, const char*const* argv)
798800
int res;
799801
if (!paramManager.get_param(argv[2], argv[3], &res)) {
800802
printf("Error: do not find %s as a parameter for congestion control algorithm %s\n", argv[3], argv[2]);
803+
exit(-5);
801804
} else {
802805
printf("tcp_%s.%s = %d\n", argv[2], argv[3], res);
803806
};
@@ -807,6 +810,7 @@ int LinuxTcpAgent::command(int argc, const char*const* argv)
807810
printf("%s %s %s %s %s\n", argv[0], argv[1], argv[2], argv[3], argv[4]);
808811
if (!paramManager.set_default_param(argv[2], argv[3], atoi(argv[4]))) {
809812
printf("Error: do not find %s as a parameter for congestion control algorithm %s\n", argv[3], argv[2]);
813+
exit(-5);
810814
};
811815
return (TCL_OK);
812816
};
@@ -815,6 +819,7 @@ int LinuxTcpAgent::command(int argc, const char*const* argv)
815819
int res;
816820
if (!paramManager.get_default_param(argv[2], argv[3], &res)) {
817821
printf("Error: do not find %s as a parameter for congestion control algorithm %s\n", argv[3], argv[2]);
822+
exit(-5);
818823
} else {
819824
printf("tcp_%s.%s = %d\n", argv[2], argv[3], res);
820825
};
@@ -824,6 +829,7 @@ int LinuxTcpAgent::command(int argc, const char*const* argv)
824829
printf("%s %s %s\n", argv[0], argv[1], argv[2]);
825830
if (!paramManager.query_param(argv[2])) {
826831
printf("Error: %s is not a congestion control algorithm or has no parameter\n", argv[2]);
832+
exit(-5);
827833
};
828834
return (TCL_OK);
829835
};

0 commit comments

Comments
 (0)