Corrected some RuboCop glitches.

Signed-off-by: Hermann Mayer <[email protected]>

Author: Jack12816

.rubocop.yml

@@ -1,5 +1,7 @@
 require:
   - rubocop-rspec
+
+plugins:
   - rubocop-rails
 
 Rails:

CHANGELOG.md

@@ -1,6 +1,6 @@
 ### next
 
-* TODO: Replace this bullet point with an actual description of a change.
+* Corrected some RuboCop glitches (#17)
 
 ### 1.6.0 (30 January 2025)
 

lib/alarmable.rb

@@ -71,7 +71,7 @@ module Alarmable
     attr_accessor :alarm_job, :alarm_base_date_property
   end
 
-  # rubocop:disable Metrics/BlockLength because Active Support like it
+  # rubocop:disable Metrics/BlockLength -- because Active Support like it
   included do
     # Hooks
     after_initialize :validate_alarm_settings, :alarm_defaults
@@ -89,16 +89,12 @@ module Alarmable
     # Getter for the alarm job class.
     #
     # @return [Class] The alarm job class
-    def alarm_job
-      self.class.alarm_job
-    end
+    delegate :alarm_job, to: :class
 
     # Getter for the alarm base date property.
     #
     # @return [Symbol] The user defined base date property
-    def alarm_base_date_property
-      self.class.alarm_base_date_property
-    end
+    delegate :alarm_base_date_property, to: :class
 
     # Set some defaults on the relevant alarm properties.
     def alarm_defaults
@@ -110,7 +106,7 @@ def alarm_defaults
     # of the specified class. Also validate the +alarm_base_date_property+
     # setting.
     #
-    # rubocop:disable Style/GuardClause because its fine like this
+    # rubocop:disable Style/GuardClause -- because its fine like this
     # :reek:NilCheck because we validate concern usage
     def validate_alarm_settings
       raise 'Alarmable +alarm_job+ is not configured' if alarm_job.nil?
@@ -151,7 +147,7 @@ def alarm_id(channel, before_minutes)
     # @return [Object] The new alarm_jobs instance (partial)
     #   Example: { "alarm id": "job id" }
     #
-    # rubocop:disable Metrics/AbcSize because its already broken down
+    # rubocop:disable Metrics/AbcSize -- because its already broken down
     # :reek:TooManyStatements because see above
     # :reek:NilCheck because we dont want to cancel 'nil' job id
     # :reek:DuplicateMethodCall because hash access is fast

spec/alarmable_spec.rb

@@ -56,7 +56,7 @@ def drop_tables(*tables)
     end
   end
 
-  # rubocop:disable RSpec/BeforeAfterAll because we are aware
+  # rubocop:disable RSpec/BeforeAfterAll -- because we are aware
   before(:all) { create_tables(*tables) }
 
   before { enqueued_jobs.clear }
@@ -222,7 +222,7 @@ def drop_tables(*tables)
       alarmable.reschedule_alarm_jobs
     end
 
-    # rubocop:disable RSpec/ExampleLength because we need 6 lines here :(
+    # rubocop:disable RSpec/ExampleLength -- because we need 6 lines here :(
     it 'cancels none updated jobs' do
       allow(alarmable).to receive(:reschedule_alarm_job)
         .and_return({ alarm_id => 'something-new' })
@@ -282,8 +282,8 @@ def drop_tables(*tables)
             raise_error(RuntimeError, /alarm_job/)
         end
 
-        # rubocop:disable RSpec/RepeatedExample because it looks like the same
-        #   but the background is different
+        # rubocop:disable RSpec/RepeatedExample -- because it looks like the
+        #   same but the background is different
         it 'raise not when set' do
           expect { TestAlarmable.new }.not_to raise_error
         end
@@ -294,8 +294,8 @@ def drop_tables(*tables)
             raise_error(RuntimeError, /alarm_job/)
         end
 
-        # rubocop:disable RSpec/RepeatedExample because it looks like the same
-        #   but the background is different
+        # rubocop:disable RSpec/RepeatedExample -- because it looks like the
+        #   same but the background is different
         it 'raise not when a class' do
           expect { TestAlarmable.new }.not_to raise_error
         end
@@ -308,8 +308,8 @@ def drop_tables(*tables)
             raise_error(RuntimeError, /alarm_base_date_property/)
         end
 
-        # rubocop:disable RSpec/RepeatedExample because it looks like the same
-        #   but the background is different
+        # rubocop:disable RSpec/RepeatedExample -- because it looks like the
+        #   same but the background is different
         it 'raise not when set' do
           expect { TestAlarmable.new }.not_to raise_error
         end
@@ -320,8 +320,8 @@ def drop_tables(*tables)
             raise_error(RuntimeError, /alarm_base_date_property/)
         end
 
-        # rubocop:disable RSpec/RepeatedExample because it looks like the same
-        #   but the background is different
+        # rubocop:disable RSpec/RepeatedExample -- because it looks like the
+        #   same but the background is different
         it 'raise not when an useable property' do
           expect { TestAlarmable.new }.not_to raise_error
         end