Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmission silently crashes on ValueError #2863

Open
7 of 8 tasks
theAkito opened this issue Jul 16, 2024 · 0 comments
Open
7 of 8 tasks

Transmission silently crashes on ValueError #2863

theAkito opened this issue Jul 16, 2024 · 0 comments

Comments

@theAkito
Copy link

Is there a pinned issue for this?

  • I have read the pinned issues and could not find my issue

Is there an existing or similar issue/discussion for this?

  • I have searched the existing issues
  • I have searched the existing discussions

Is there any comment in the documentation for this?

  • I have read the documentation, especially the FAQ and Troubleshooting parts

Is this related to a provider?

  • I have checked the provider repo for issues
  • My issue is NOT related to a provider

Are you using the latest release?

  • I am using the latest release

Have you tried using the dev branch latest?

  • I have tried using dev branch

Docker run config used

I'm using a docker-compose.yml. This compose file has worked for years and suddenly it stopped, even though I did not change anything.

The relevant part is this environment variable.

TRANSMISSION_RATIO_LIMIT

I had set it to 2.0. Always worked. Suddenly, it started getting a ValueError, because this Float was parsed as an Int.

Transmission always silently failed. You could only see that it failed, when you exec into the container and run something like ps auxf, to see OpenVPN, but not Transmission running.

The initial error, indicating that something was wrong in the first place, was connection refused when trying to connect to 9091.

Current Behavior

ValueError on Float, without warning.
Transmission not running is never indicated or noticed by the deployment.

Expected Behavior

When Transmission crashes for whatever reason, it should crash the entire container or at least show a big fat ERROR in the logs, repeatedly.

Whether parsing the number as Float, rather than Int, makes more sense, is debatable.

How have you tried to solve the problem?

Changed Float to Int.

Log output

Could not coerce TRANSMISSION_RATIO_LIMIT value 2.0 to expected type <class 'int'>                                                                                                                                                                                                                      
Traceback (most recent call last):                                                                                                                                                                                                                                                                      
  File "/etc/transmission/updateSettings.py", line 74, in <module>                                                                                                                                                                                                                                      
    env_value = setting_type(env_value)                                                                                                                                                                                                                                                                 
ValueError: invalid literal for int() with base 10: '2.0'

HW/SW Environment

- OS: DietPi v8.14.2 (based on Debian 11 Bullseye)
- Docker: 23.0.1, build a5ee5b1

Anything else?

When Transmission is not working, OpenVPN running, as if nothing were wrong, is misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant