Render Availabilities as TimeSlots in Scheduler View from FreeBusy API #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endering timeslots upon change in date * mapped the returned array to render in the timeslot selection area of the scheduler or returns "not available message" if there is no availability * request query params takes in day, month, year, duration, and user for freebusy query to work correctly
…ight larger than 300px
bonnieli
reviewed
Dec 14, 2020
| const [selectedDay, setSelectedDay] = useState(null); | ||
| const [selectedDay, setSelectedDay] = useState({ | ||
| day: tomorrowsDate.getDate(), | ||
| month: tomorrowsDate.getMonth() + 1, |
There was a problem hiding this comment.
how come this needs to be + 1?
There was a problem hiding this comment.
if it's due to indices, maybes make a note of this in a comment
There was a problem hiding this comment.
yeah, regular JavaScript indexes the months starting with 0 whereas this library indexes it with 0, so December in the .getMonth() method returns 11, but to display it as December for this library, it should be 12 which is where the ...+ 1 adjusts it to.
| // request.query.meetingTypeID | ||
| // request.query.date // must be in datetime format | ||
| availabilitiesRouter.get("/freebusy", async (request, response) => { | ||
| const { day, month, year } = request.query; |
There was a problem hiding this comment.
Suggested change
| const { day, month, year } = request.query; | |
| const { day, month, year, duration, user } = request.query; |
There was a problem hiding this comment.
I believe this has to be
Suggested change
| const { day, month, year } = request.query; | |
| let{ day, month, year, duration, user } = request.query; |
in order to reassignment of
duration = Number(duration)
user = await User.findbyId(user)in the suggestions below:
| // request.query.date // must be in datetime format | ||
| availabilitiesRouter.get("/freebusy", async (request, response) => { | ||
| const { day, month, year } = request.query; | ||
| const duration = Number(request.query.duration); |
There was a problem hiding this comment.
Suggested change
| const duration = Number(request.query.duration); | |
| const duration = Number(duration); |
| availabilitiesRouter.get("/freebusy", async (request, response) => { | ||
| const { day, month, year } = request.query; | ||
| const duration = Number(request.query.duration); | ||
| const user = await User.findById(request.query.user); |
There was a problem hiding this comment.
Suggested change
| const user = await User.findById(request.query.user); | |
| const user = await User.findById(user); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it Does:
When there is Availability:
When There Isn't:
What to Look For:
What To Avoid