Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.35.0 no longer supports "extensions: null" in query #10013

Closed
jflambert opened this issue Nov 23, 2023 · 4 comments
Closed

v2.35.0 no longer supports "extensions: null" in query #10013

jflambert opened this issue Nov 23, 2023 · 4 comments
Assignees
Labels
k/bug Something isn't working t/gql-services

Comments

@jflambert
Copy link
Contributor

Version Information

Server Version: v2.35.0

Environment

OSS

What is the current behaviour?

v2.34 and below supported "extensions": null
v2.35 and up crashes with: parsing PersistedQueryRequest failed, expected Object, but encountered Null

What is the expected behaviour?

I want the same behaviour as v2.34 in v2.35 and up

How to reproduce the issue?

  1. Query hasura v2.35 with {"query":"{ __schema { queryType { fields { name } } } }","variables":null,"operationName":null, "extensions":null}
  2. Fails with parsing PersistedQueryRequest failed, expected Object, but encountered Null
  3. Remove "extensions":null from the query.
  4. Query works.

Screenshots or Screencast

image

image

Any possible solutions/workarounds you're aware of?

Removing "extensions":null

@jflambert jflambert added the k/bug Something isn't working label Nov 23, 2023
@jflambert
Copy link
Contributor Author

This is the commit that broke compatibility with "extensions": null

203b85a

@marionschleifer
Copy link
Contributor

Hi @jflambert, thank you for reporting that. We're looking into this right now and will get back when we have a fix.

@manasag
Copy link
Contributor

manasag commented Dec 7, 2023

This fix is going to arrive in 2.36 due to release this week.

@jflambert
Copy link
Contributor Author

@marionschleifer @manasag you can close this now...

@rikinsk rikinsk closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k/bug Something isn't working t/gql-services
Projects
None yet
Development

No branches or pull requests

5 participants