Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification github action for PR #133

Open
myShoggoth opened this issue Oct 7, 2021 · 1 comment
Open

Verification github action for PR #133

myShoggoth opened this issue Oct 7, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@myShoggoth
Copy link
Contributor

With the new changes in the hakyll branch, we have an infrastructure that can build and then deploy to the main branch.

Next we need the same kind of CI for PRs into that branch that does the build, and hopefully later some verification steps, but no deploy.

@myShoggoth myShoggoth added good first issue Good for newcomers help wanted Extra attention is needed enhancement New feature or request labels Oct 7, 2021
@visortelle
Copy link

visortelle commented Dec 30, 2021

I enabled build for all branches instead of only for hakyll.
Also I added conditional deployment step skiping for pull request in this PR:

#170

How it looks on CI:

Screen Shot 2021-12-30 at 1 00 06 PM

Example here:

https://github.com/visortelle/haskellfoundation.github.io/runs/4666439616?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants