Different strategy about parsing NotificationMessage

[July541]

I just found generated model dropped addNullField for notification messages, which may be one of the causes of haskell/vscode-haskell#920.

Does it intentionally?

/cc @michaelpj

master:

lsp/lsp-types/src/Language/LSP/Protocol/Message/Types.hs

Lines 111 to 112 in 8ab6604

	instance (FromJSON (MessageParams m), FromJSON (SMethod m)) => FromJSON (TNotificationMessage m) where
	parseJSON = genericParseJSON lspOptions

older:

lsp/lsp-types/src/Language/LSP/Types/Message.hs

Lines 260 to 261 in 596376a

	instance (FromJSON (MessageParams m), FromJSON (SMethod m)) => FromJSON (NotificationMessage m) where
	parseJSON = genericParseJSON lspOptions . addNullField "params"

[michaelpj]

Argh, I suspect this is indeed a regression. Sorry about that. I'll try to get a fix out and included in the next HLS. Do you know if this change fixes the issue you saw?

[July541]

Do you know if this change fixes the issue you saw?

Thanks for the timely work! I compiled your fix and parsing failed doesn't appear more!

As for haskell/vscode-haskell#920, it still exists but irrelated to this.