Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move haskell-utils-* from haskell-commands.el to utils package if possible, rename otherwise #728

Closed
10 tasks done
geraldus opened this issue Jun 18, 2015 · 2 comments
Closed
10 tasks done

Comments

@geraldus
Copy link
Contributor

There are several utility functions defined in haskell-commands.el. I think it's better to move them into haskell-utils.el if possible, and rename prefix to haskell-commands-. I think we can move those functions which does not depends on other haskell-mode functionality, for example haskell-utils-capture-expr-bounds uses haskell-spanable-pos-at-point internally and likely it is first candidate to rename rather than move.

Here is a list of this functions:

  • haskell-utils-async-post-command-flag1
  • haskell-utils-capture-expr-bounds2
  • haskell-utils-compose-type-at-command3
  • haskell-utils-insert-type-signature4
  • haskell-utils-echo-or-present5
  • haskell-utils-async-update-post-command-flag6
  • haskell-utils-async-watch-changes7
  • haskell-utils-async-stop-watching-changes8
  • haskell-utils-reduce-string9
  • haskell-utils-parse-repl-response10
@gracjan
Copy link
Contributor

gracjan commented Jun 19, 2015

I have removed all confusing statements. Now it is well-defined :)

@geraldus
Copy link
Contributor Author

geraldus commented Jul 7, 2015

Nice! #752 covered all stuff, can be closed now. Good job, @ankhers !

@geraldus geraldus closed this as completed Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants