Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting in SQL quasi-quoter is broken #1289

Closed
bgamari opened this issue Apr 12, 2016 · 3 comments
Closed

Syntax highlighting in SQL quasi-quoter is broken #1289

bgamari opened this issue Apr 12, 2016 · 3 comments

Comments

@bgamari
Copy link

bgamari commented Apr 12, 2016

Consider this program,

sql = [sql| SELECT f1, f2 FROM aTable |]
xml = [xml| <html><body id="hi">hello</body></html> |]

I have ("sql" . sql-mode)) in haskell-font-lock-quasi-quote-modes yet the body of the quoter gets no syntax highlighting whatsoever. If I past the body into a new buffer and enter sql-mode manually it is highlighted as one would expect, so presumably it works as expected. The xml quote is also highlighted as one would expect, so quasi-quoting highlighting isn't generally broken. It seems to be particular to SQL.
@bgamari
Copy link
Author

bgamari commented Apr 12, 2016

It seems that javascript-mode may be affected as well.

@gracjan
Copy link
Contributor

gracjan commented Apr 13, 2016

Can you run make check and see if it goes through? We have a test for sql-mode so it should fail if there is something wrong.

@bgamari
Copy link
Author

bgamari commented Apr 23, 2016

Indeed updating emacs seemed to help.

@bgamari bgamari closed this as completed Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gracjan @bgamari