Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Deprecate haskell-mode-contextual-space #1182

Closed
geraldus opened this issue Feb 24, 2016 · 4 comments
Closed

[Discussion] Deprecate haskell-mode-contextual-space #1182

geraldus opened this issue Feb 24, 2016 · 4 comments

Comments

@geraldus
Copy link
Contributor

This is from online haskell-mode manual

4.2.5 Entering imports

If you have Haskell Interactive Mode enabled and a session open, you can write

import

And then hit SPC (running M-x haskell-mode-contextual-space) which will prompt a list of all modules, either installed modules or local project directory files. Then it’ll insert it and then format that module section.

haskell-mode-contextual-space[1] seems not to be used at all these days and is not bound to any key sequence[2]. It provides following functionality:

  • prompt user to select module name when pressed SPC after import keyword (using haskell-complete-module-read)
    • it does not provide qualified import support
    • modules list comes from session
  • echoes identifier info to mini-buffer (using haskell-process-do-try-info)
  • it requires interactive haskell mode to be enabled and session to be present, otherwise it does nothing

Module import is simplified by auto completions. Identifier info in mini-buffer is questionable. I'd rather see identifier type signature. But since it is not used in any other function, not bound to any key sequence, and do not provide any unique feature should we drop it completely deprecate it along with haskell-mode-contextual-import-completion[3]?

@geraldus geraldus changed the title [Discussion] drop haskell-mode-contextual-space [Discussion] deprecate haskell-mode-contextual-space Mar 2, 2016
@gracjan gracjan changed the title [Discussion] deprecate haskell-mode-contextual-space [Discussion] Deprecate haskell-mode-contextual-space Mar 5, 2016
@gracjan
Copy link
Contributor

gracjan commented Mar 5, 2016

Agreed. Last time a guy tried to use it he was burned in #572. Just remove it, no deprecation needed.

@geraldus
Copy link
Contributor Author

geraldus commented Mar 5, 2016

Will do in few hours

@geraldus
Copy link
Contributor Author

geraldus commented Mar 5, 2016

@gracjan by the way how long we keep obsolete code in?

@gracjan
Copy link
Contributor

gracjan commented Mar 5, 2016

We do not have specific rules about deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants