StylishHaskell shifting the working dir, this could lead to race condition

[soulomoon]

StylishHaskell shifting the working dir, it could make other part of hls depending on cwd result in error in some race condition.

haskell-language-server/plugins/hls-stylish-haskell-plugin/src/Ide/Plugin/StylishHaskell.hs

Line 81 in 61fd5c4

loadConfigFrom file = do

Such as Hlint, Stan, Template haskel, session loader etc. We should not shifting the working dir after initilization.

[soulomoon]

#4231 Could alleviate the some potential race condition. But there are still a lot of place we could not clean up

[soulomoon]

I am wondering if there is an alternaive function than loadConfig that does not depend on cwd to load the stylish config.

[michaelpj]

We could ask upstream to expose a version that takes the directory as an argument.

[soulomoon]

Yep, I've craete an issue there

[fendor]

This is quite bad 😅 Perhaps we can copy-paste the loadConfig code from stylish-haskell and fix it ourselves until upstream fixed it?

[jhrcek]

Seems like stylish's loadConfig already supports specifying directory as argument (Maybe FilePath). We just need to pass Just instead of Nothing, or am I missing something?

[jhrcek]

Ok, the Maybe FilePath is the path to the stylish config file itselt, not to a "starting directory" as I imagined.
So this will require some upstream changes after all 😞