Skip to content

display info on hover not working when ambiguous definition occurs #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AustinZhu opened this issue Aug 2, 2020 · 2 comments
Open
Labels
status: in discussion Not actionable, because discussion is still ongoing or there's no decision yet

Comments

@AustinZhu
Copy link

Steps to reproduce this problem:

  1. create a single .hs file
  2. import some module and define a function whose name collides with a function in the module.
  3. save the file and restart VS Code

In my case, it does highlight the error that ambiguous definition occurs, but it seems that the extension is not inspecting other parts of the code. When I hover on a function or a variable, it shows an empty small window instead of the definition.

@fendor
Copy link
Collaborator

fendor commented Aug 2, 2020

This is to be expected, since we typecheck the project and provide hover information based on the type checking information. If you introduce an error now, we can use the information from the last successful typecheck for hover. If you close your session and open it from new, we don't have all the caches, so some features don't work

@lukel97 lukel97 transferred this issue from haskell/vscode-haskell Aug 2, 2020
@AustinZhu
Copy link
Author

Thank you for the reply! It would be great if some improvement can be made to deal with this issue. I'm not sure if the typecheck infomation can be preserved or there is a way to circumvent naming conflicts when doing typecheck :).

@Ailrun Ailrun added the status: in discussion Not actionable, because discussion is still ongoing or there's no decision yet label Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in discussion Not actionable, because discussion is still ongoing or there's no decision yet
Projects
None yet
Development

No branches or pull requests

3 participants