Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More user friendly about using mirror #852

Open
July541 opened this issue Jul 12, 2023 · 4 comments
Open

More user friendly about using mirror #852

July541 opened this issue Jul 12, 2023 · 4 comments

Comments

@July541
Copy link
Contributor

July541 commented Jul 12, 2023

I'm not sure it is worth it because we don't have many mirrors, but at least let me write sth.

  1. Try to use a mirror if the default connection gets lost.
  2. Add a subcommand like ghcup mirror to list all available mirrors or specify a mirror.
  3. Integrate with Create 'ghcup healthcheck' command #701, suggest using a mirror if network issues.
@hasufell
Copy link
Member

Mirror support has already been overhauled, so it might not be that difficult, see #700

@July541
Copy link
Contributor Author

July541 commented Jul 12, 2023

Can you please clarify, what so it might not be that difficult mean? Does it mean we should keep the current state?

@hasufell
Copy link
Member

I don't know man. See the PR. You can already define arbitrary mirrors. Suggest a specific user experience/API if you have one.

@hasufell
Copy link
Member

Ok, sorry for the flippant comments. I didn't have a great week.

Let's go over it one by one:

Try to use a mirror if the default connection gets lost.

That makes sense, but in order to do that, we first need:

  1. an actual mirror (I had plans to prototype that... but I never got around it)
  2. a way to turn this behavior off... some users might now want this behavior. And then the question is also: should this be default?

Add a subcommand like ghcup mirror to list all available mirrors or specify a mirror.

I can imagine:

  1. ghcup mirror list [--country=<country>]
  2. ghcup mirror set <mirror|default>
  3. ghcup mirror test with latency information

Integrate with #701, suggest using a mirror if network issues

Possible, if we ever implement the healthcheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants