Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full URIs prevent mirrors from distributing signed metadata #704

Closed
kylerky opened this issue Dec 6, 2022 · 1 comment
Closed

Full URIs prevent mirrors from distributing signed metadata #704

kylerky opened this issue Dec 6, 2022 · 1 comment
Labels
duplicate This issue or pull request already exists type: improvement

Comments

@kylerky
Copy link

kylerky commented Dec 6, 2022

Metadata files include full URIs of the downloads. However, mirrors need to change the URIs in order to direct GHCup to the mirror sites, which invalidates the signatures of the metadata files.

A possible solution is to use relative paths in metadata and to allow users to specify a base URI for their downloads.
@hasufell
Copy link
Member

hasufell commented Dec 6, 2022

Duplicate: #357

There's already a PR: #700

@hasufell hasufell closed this as completed Dec 6, 2022
@hasufell hasufell added duplicate This issue or pull request already exists type: improvement labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists type: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hasufell @kylerky