Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per file options #10552

Open
hsyl20 opened this issue Nov 15, 2024 · 0 comments
Open

Per file options #10552

hsyl20 opened this issue Nov 15, 2024 · 0 comments

Comments

@hsyl20
Copy link
Collaborator

hsyl20 commented Nov 15, 2024

To build GHC's RTS, Hadrian uses some feature that isn't available in cabal (afaik): setting custom cc-options or cpp-options per file/glob.

See https://gitlab.haskell.org/ghc/ghc/-/blob/8f2e08320f846ed72ef0306ebbe75bdb3752226a/hadrian/src/Settings/Packages.hs#L403:

          -- We're after pure performance here. So make sure fast math and
          -- vectorization is enabled.
          , input "**/Hash.c" ? pure [ "-O3" ]

          , inputs ["**/Evac.c", "**/Evac_thr.c"] ? arg "-funroll-loops"

          , speedHack ?
            inputs [ "**/Evac.c", "**/Evac_thr.c"
                   , "**/Scav.c", "**/Scav_thr.c"
                   , "**/Compact.c", "**/GC.c" ] ? arg "-fno-PIC"

It would be nice to convert this into proper Cabal entries so that we get one step closer to build the boot libraries with cabal. Something like:

    cc-options-custom:
        <glob> <options>
    cpp-options-custom:
        <glob> <options>
    ghc-options-custom:
        <glob> <options>

E.g.

    cc-options-custom:
        **/Compact.c -finline-limit=2500
        **/Hash.c    -O3
        {**/Evac.c,**/Evac_thr.c} -funroll-loops

    if flag(speedHack)
      cc-options-custom:
        **/{Evac.c, Evac_thr.c, Scav.c, Scav_thr.c, Compact.c, GC.c} -fno-PIC

    cpp-options-custom:
        **/RtsUtils.c -DProjectVersion=foo -DHostPlatform=bar ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant