Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full node handling is mostly untested #445

Open
sjakobi opened this issue Apr 27, 2022 · 1 comment
Open

Full node handling is mostly untested #445

sjakobi opened this issue Apr 27, 2022 · 1 comment
Labels
tests

Comments

@sjakobi
Copy link
Member

sjakobi commented Apr 27, 2022

The problem is that to create a Full node, the hashes need to come in a very particular shape. For example, to create a Full root node, the hash data needs to cover all 32 (maxChildren) combinations for the lowest 5 (bitsPerSubkey) bits. I believe the current test input generators will very rarely produce such data if at all.
@sjakobi sjakobi added the tests label Apr 27, 2022
@sjakobi sjakobi mentioned this issue Apr 27, 2022
Merged
4 tasks
@sjakobi
Copy link
Member Author

sjakobi commented Apr 27, 2022

Ideally we can address this by completely removing the Full constructor (#399).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjakobi