Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of some internal functions could be better #437

Open
4 tasks
sjakobi opened this issue Apr 25, 2022 · 0 comments
Open
4 tasks

Naming of some internal functions could be better #437

sjakobi opened this issue Apr 25, 2022 · 0 comments
Labels
documentation maintenance

Comments

@sjakobi
Copy link
Member

sjakobi commented Apr 25, 2022

  • updateOrSnocWith[Key]: Nothing in this name indicates that this function is for Collision handling! Could be named insertCollisionWith[Key]#.
  • updateOrConcatWithKey: Same problem. How about unionCollisionWithKey#?!
  • updateWith#: Same problem. adjustCollision#?!
  • clone: Thaws an array of maxChildren elements. Let's just inline it into update32M.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjakobi