Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourcePos leaks into the inherit shorthand #326

Closed
Profpatsch opened this issue Jun 25, 2018 · 1 comment
Closed

SourcePos leaks into the inherit shorthand #326

Profpatsch opened this issue Jun 25, 2018 · 1 comment

Comments

@Profpatsch
Copy link
Contributor

inherit :: [NKeyName e] -> SourcePos -> Binding e
where before it was just inherit :: [NKeyName e] -> Binding e.
Same with inheritFrom.

As the shorthands module is for generating nix expression, not defaulting to nullPos doesn’t really make sense (since the user is not a parser and has no access to a filename or source position).

@Profpatsch Profpatsch changed the title SourcePos leaks into the inherit helper SourcePos leaks into the inherit shorthand Jun 25, 2018
@jwiegley
Copy link
Member

jwiegley commented Sep 8, 2018

Agreed, @Profpatsch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants