Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommended threshold for the log likelihood ratio #129

Open
PengNi opened this issue Apr 18, 2023 · 4 comments
Open

recommended threshold for the log likelihood ratio #129

PengNi opened this issue Apr 18, 2023 · 4 comments

Comments

@PengNi
Copy link

PengNi commented Apr 18, 2023

Hi @hasindu2008 and all,

For the f5c meth-freq step, is the reommended threshold for the log likelihood ratio still 2.5, or should be 2.0 as nanopolish has changed?

Thank you in advance!

Best,
Peng

@hasindu2008
Copy link
Owner

Hi

For f5c meth-freq, I have not implemented this scaling based on the group size discussed here jts/nanopolish#695. That lowering of llr to 2.0 is only suitable if that group scaling is implemented as I understand.

What kind of data are you working on? R9 or R10?

@PengNi
Copy link
Author

PengNi commented Apr 18, 2023

Hi @hasindu2008 , I am using R9.4.1 reads.

@hasindu2008
Copy link
Owner

I could implement an option for group-based scaling and if you are interested in getting the llr to 2.0

@PengNi
Copy link
Author

PengNi commented Apr 18, 2023

Thank you, for now I will use 2.5. If it doesn't take you a long time to implement it, I am very interested. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants