This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 330
feature: Waypoint Server Upgrade command for supported server platforms #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds server upgrades for docker, nomad, and k8s. It attempts to upgrade waypoint server in place, and additionally takes a snapshot of the server by default should anything go wrong with the upgrade.
briancain
changed the title
feature: Waypoing Server Upgrade command for supported server platforms
feature: Waypoint Server Upgrade command for supported server platforms
Jan 13, 2021
I see in PR #972 it's abstracted out the serverName and serviceName (k8s only). I'll be sure to do the same here once I can rebase off of Uninstall, or I can make the same changes here and let git handle it 😄 edit: done! |
krantzinator
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
From testing with Nomad version 1.0.1 and 1.0.2, it looks like this is no longer an issue. Job upgrades preserve the DB, so no need to document this anymore.
In some cases, k8s using RollingUpdate with a heavy load might take longer to refresh the image. We should wait a little bit before failing to verify the sever client connection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new CLI command:
waypoint server upgrade
. For each supported server platform, it attempts to upgrade the server image in place while preserving the original database. It also by default takes a snapshot of the sever prior to upgrading in the case of any failures.Fixes #612