This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 330
internal/server: refactor install into one package #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
suggested changes
Dec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeahhhhhhh this is way cleaner.
Just a couple tiny comments but this is good work.
mitchellh
approved these changes
Dec 4, 2020
briancain
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📦 🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundation to addressing #672 and #612
There's a lot of diff from moving existing code around, so I'll highlight actual changes here:
Installer
interface, replacing thecase
setup inInstallCommand
to set the platformserverinstall.Config
out ofInstallCommand
and gave eachPlatform
its own configserverinstall/config
package; toyed with usingserverconfig
; moved theInstallFlags
pieces fromInstallCommand
toserverinstall
to separate packages and back again. I also worked on this piece with a couple teammates, experimenting with different ways to have generic flags and install them to the scoped platforms as part of init. Ultimately I decided to go with the Platform-specific flags you see here in order to overcome the various hurdles discovered.Small pieces:
pull-policy
flag, and updated the flag to have an updated value ofIfNotPresent
to match k8s default (ImagePullPolicy: apiv1.PullPolicy(c.ImagePullPolicy),
strings.ToLower
on the platform name for UXCopying Evan's example of including examples in lieu of a CLI testing framework: