Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

fix(cli): honor runner install -platform arg #4699

Merged
merged 1 commit into from
May 11, 2023
Merged

fix(cli): honor runner install -platform arg #4699

merged 1 commit into from
May 11, 2023

Conversation

jgwhite
Copy link
Contributor

@jgwhite jgwhite commented May 11, 2023

Currently we’re only assigning a value to runnerPlatform if c.platform is empty, leading to the following bug:

$ waypoint runner install -platform=docker
! Error installing runner into "": unsupported platform

This patch ensures we use the given value for c.platform.

$ waypoint runner install -platform=docker
✓ Finished connecting to: host.docker.internal:9701

@jgwhite jgwhite added bug Something isn't working core/cli labels May 11, 2023
@jgwhite jgwhite self-assigned this May 11, 2023
@jgwhite jgwhite requested a review from a team as a code owner May 11, 2023 21:22
briancain
briancain approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh noooo, good find 🙈

@jgwhite jgwhite force-pushed the runner-install-platform-fix branch from 53479a9 to 8d84f40 Compare May 11, 2023 21:23
@jgwhite jgwhite merged commit df527ae into main May 11, 2023
@jgwhite jgwhite deleted the runner-install-platform-fix branch May 11, 2023 21:48
@hc-github-team-waypoint hc-github-team-waypoint mentioned this pull request May 11, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

Assignees

@jgwhite jgwhite

Labels
backport/0.11.x bug Something isn't working core/cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgwhite @briancain