This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Bug fix: Filter out empty names from context list #4257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some operating systems (namely macOS), it's possible for something akin to a
.DS_Store
file to exist in the directory where contexts are stored. If so, then when a user runswaypoint context list
an internal methodnameFromPath
returns an empty string for said file as it doesn't have a normal file extension.context list
then tries to load a non-existing/.hcl
file and errors like so:In this PR we simply filter out any non
.hcl
files before we callnameFromPath
, which should save us from any other possible.dotfiles
or other files that don't have a file extension at all. It would be odd to have any others in that folder but this should hopefully Catch'em All