This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 330
Consul Config Sourcer Plugin #4045
Merged
paladin-devops
merged 10 commits into
hashicorp:main
from
paladin-devops:consul-configsourcer
Oct 20, 2022
Merged
Consul Config Sourcer Plugin #4045
paladin-devops
merged 10 commits into
hashicorp:main
from
paladin-devops:consul-configsourcer
Oct 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaolin-ninja
approved these changes
Oct 12, 2022
catsby
reviewed
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of nit-pick things, most of which are inconsequential but a few I'd like your thoughts on before 👍
briancain
reviewed
Oct 13, 2022
The function to start a Consul blocking query will now be called via a goroutine, rather than the contents of the function being entirely wrapped inside an anonymous function, called via a goroutine.
briancain
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Update Consul config sourcer plugin to sleep for 5 seconds before hitting the Consul KV API again, if there is no value change.
catsby
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new config sourcer plugin to support dynamic configuration from the Consul KV data store.
Example config source settings:
waypoint config source-set -type=consul -config=address=$CONSUL_HTTP_ADDR -config=token=$CONSUL_HTTP_TOKEN
Example
waypoint.hcl
snippet using this plugin:This plugin was authored by @mkeeler! 🎉