This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Add more Helm options #3950
Merged
Add more Helm options #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looking great @denysvitali! In addition to my feedback, I think we also need to generate the documentation for this PR's plugin changes. With our Makefile, you can run make gen/website-mdx to do that automatically. 😄 I've run into issues with generating the docs in the past myself as a contributor, but it works like a charm now! Let us know if you need a hand.
paladin-devops
approved these changes
Sep 30, 2022
paladin-devops
added
backport/website
paladin-devops
approved these changes
Sep 30, 2022
paladin-devops
removed
the
backport/website
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the following new Helm options:
create_namespaceskip_crds