This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
WatchTask for Nomad Task Launcher
#3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements WatchTask for getting Nomad allocation logs from the Waypoint ODR.
paladin-devops
force-pushed
the
f-nomad-watch-task
branch
from
f4a9192 to
2681e60
Compare
paladin-devops
commented
Sep 2, 2022
builtin/nomad/task.go
Outdated
| task := tg.Tasks[0] | ||
|
|
||
| // We'll give the ODR 5 minutes to start up | ||
| // TODO: Make this configurable |
There was a problem hiding this comment.
I hadn't planned on including this in the PR, but will give it a try!
There was a problem hiding this comment.
Will add in future PR!
demophoon
reviewed
Sep 2, 2022
briancain
suggested changes
Sep 6, 2022
Co-authored-by: Brian Cain <[email protected]>
briancain
suggested changes
Sep 6, 2022
Co-authored-by: Brian Cain <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3714.
The task launcher Nomad plugin will use the Nomad API to stream logs from the Nomad allocation which is running the Waypoint on-demand runner container. These logs will be available in the log output of the static runner. This means that long after the ODR job is purged from Nomad, the ODR's logs are consumable from the static runner, which runs indefinitely, making troubleshooting of remote operations easier since previously, the ODR logs were unavailable (unless the operator quickly got the ODR's logs with
nomad logsor in the Nomad UI before it was purged).