Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

Fix the appening deprecating warning being fatal #3605

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Fix the appening deprecating warning being fatal #3605

merged 5 commits into from
Jul 27, 2022

Conversation

evanphx
Copy link
Contributor

@evanphx evanphx commented Jul 26, 2022 •
edited
Loading

Fixes #3601

@evanphx evanphx requested review from briancain, izaaklauer and a team July 26, 2022 21:43
@github-actions github-actions bot added the core label Jul 26, 2022
izaaklauer
izaaklauer suggested changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@izaaklauer izaaklauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Returning ValidationResults separately makes sense to me. One suggestion to update to the new softer wording as discussed with @briancain, but happy to discuss it.

@evanphx evanphx requested a review from izaaklauer July 26, 2022 21:51
catsby
catsby approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment on the strong wording that we will remove multi-apps things. nvm it was updated while I was typing that comment lol

Other nit about Errors() vs. HasErrors() but overall LGTM

briancain
briancain approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And fixes up the hard failure for me in my testing 👍🏻

@evanphx evanphx added the backport/0.9.x Automerge PR into release/0.9.x branch after merge to main label Jul 26, 2022
@evanphx evanphx merged commit fc3eee9 into main Jul 27, 2022
@evanphx evanphx deleted the b-dep-warning branch July 27, 2022 00:19
@hc-github-team-waypoint hc-github-team-waypoint mentioned this pull request Jul 27, 2022
Merged
@catsby catsby mentioned this pull request Aug 8, 2022
Merged
@hc-github-team-waypoint hc-github-team-waypoint mentioned this pull request Aug 9, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

@briancain briancain briancain approved these changes

@izaaklauer izaaklauer izaaklauer approved these changes

Assignees
No one assigned
Labels
backport/0.9.x Automerge PR into release/0.9.x branch after merge to main core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning is a hard failure
4 participants
@evanphx @catsby @briancain @izaaklauer