Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

chore: add hcl replace #3522

Merged
merged 3 commits into from
Jul 12, 2022
Merged

chore: add hcl replace #3522

merged 3 commits into from
Jul 12, 2022

Conversation

thiskevinwang
Copy link
Contributor

@thiskevinwang thiskevinwang added backport/website Automerge PR into stable-website branch after merge to main backport/0.8.x labels Jul 2, 2022
@briancain briancain requested a review from a team July 11, 2022 21:20
@briancain briancain added backport/0.9.x Automerge PR into release/0.9.x branch after merge to main and removed backport/0.8.x labels Jul 11, 2022
briancain
briancain suggested changes Jul 11, 2022
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small comment about the doc string!

pkg/config/funcs/doc.go Outdated Show resolved Hide resolved
@thiskevinwang thiskevinwang requested a review from briancain July 11, 2022 22:02
@briancain briancain removed the backport/0.9.x Automerge PR into release/0.9.x branch after merge to main label Jul 12, 2022
@briancain briancain merged commit 86ac9f7 into main Jul 12, 2022
@briancain briancain deleted the kevin/hcl-replace branch July 12, 2022 18:49
This was referenced Jul 12, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

Assignees
No one assigned
Labels
backport/website Automerge PR into stable-website branch after merge to main website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiskevinwang @briancain