This repository was archived by the owner on Jan 8, 2024. It is now read-only.
cli: Fix panic in waypoint plugin cli
#3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if a user just ran `waypoint plugin` with no arguments, the CLI would panic assuming that an argument was passed in. This commit fixes that by looking at the argument slice and printing an error if none was passed in. It fixes up some of the other panics to print errors and return 1.
briancain
added
pr/no-changelog
briancain
removed
the
pr/no-changelog
evanphx
approved these changes
Mar 14, 2022
catsby
approved these changes
Mar 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if a user just ran
waypoint pluginwith noarguments, the CLI would panic assuming that an argument was passed in.
This commit fixes that by looking at the argument slice and printing an
error if none was passed in. It fixes up some of the other panics to
print errors and return 1.