Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

K8s: Don't error build/deploy/release because a previous deployment isn't found #3070

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Mar 4, 2022

If for some reason a previous deployment is not found and on waypoint up we try to remove it, the entire operation will be reported as a failure even if we successfully deployed a new version.

Here we check for not found, and simply continue

@catsby catsby added pr/no-changelog No automatic changelog entry required for this pull request plugin/k8s labels Mar 4, 2022
@github-actions github-actions bot added the plugin label Mar 4, 2022
@catsby catsby removed the pr/no-changelog No automatic changelog entry required for this pull request label Mar 4, 2022
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, makes sense! We're already destroying it anyway 👍🏻

@briancain
Copy link
Member

Backport?

@catsby
Copy link
Contributor Author

catsby commented Mar 8, 2022

Backport?

@briancain agreed, backporting to 0.7.x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants