This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/server: Ensure on-demand runner config exists before start job #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
added
pr/no-changelog
briancain
removed
the
pr/no-changelog
Prior to this commit, if the state package returned nil or nothing for an on-demand runner config based on the id set for a job, Waypoint would still attempt to queue the job with a nil ODR config. This leads to a panic immediately after when we attempt to set environment variables from the ODR config for the job on a nil config. This commit fixes that by returning an error if the requested ODR config does not exist in the state database.
briancain
force-pushed
the
odr-no-profile-for-job
branch
from
73218fd to
74c99a5
Compare
evanphx
approved these changes
Mar 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if the state package returned nil or nothing for
an on-demand runner config based on the id set for a job, Waypoint would
still attempt to queue the job with a nil ODR config. This leads to a
panic immediately after when we attempt to set environment variables
from the ODR config for the job on a nil config. This commit fixes that
by returning an error if the requested ODR config does not exist in the
state database.
This is related to #3051 but
mainly fixes the bad behavior with the panic, not the core bug of a invalid
or missing ODR config set on a job.