Fix for empty deployUrl check in deployment_create

[gunadhya]

Fixes #2645

I'm new to this project so please let me know if any updates are needed.

[xiaolin-ninja]

Thanks for making the PR @gunadhya and you're on the right track! We already have a template defined when URL service is disabled, I would suggest refactoring the case switch statement to hit that code.

[gunadhya]

Oh! Do you mean a new case like this?

    case releaseUrl != "" && deployUrl == "":
	app.UI.Output(strings.TrimSpace(deployNoURL)+"\n", terminal.WithSuccessStyle())
	app.UI.Output("   Release URL: %s", releaseUrl, terminal.WithSuccessStyle())

[xiaolin-ninja]

I meant a case deployUrl == "" that wouldn't print out the release URL, but thinking more about it we do want the release URL too, so an if statement inside the releaseUrl case was the proper approach, I'd do something like

case releaseUrl != "":
    printInplaceInfo(inplace,app)
    app.UI.Output(" Release URL: %s", releaseUrl, terminal.WithSuccessStyle())
    if deployUrl != "" {
        app.UI.Output("Deployment URL: https://%s", deployUrl 
    } else {
        app.UI.Output(strings.TrimSpace(deployNoURL)+"\n", terminal.WithSuccessStyle())
    }

[xiaolin-ninja]

LGTM!

[briancain]

Hey there @gunadhya - could you please add a changelog? Our guide on how to do this is here: https://github.com/hashicorp/waypoint/blob/main/.github/CHANGELOG_GUIDE.md

This is a bug fix type

[gunadhya]

I've added a changelog. If there are any other beginner/Intermediate issues in this project, I'd be happy to work on them.

[briancain]

Hey @gunadhya - The changelog file name should match this pull request, so it should be updated to

.changelog/2755.txt

Thanks!

Otherwise I think we're good to merge.

[gunadhya]

Oh I'll get right on it. Does the documentation needed to be updated https://github.com/hashicorp/waypoint/blob/main/.github/CHANGELOG_GUIDE.md#changelog-entry-examples
Cause over there it suggested issue number.

[briancain]

Oops, yep, that should be updated! Sorry about that ❤️

[briancain]

I've added a changelog. If there are any other beginner/Intermediate issues in this project, I'd be happy to work on them.

Hmm, will have to get back to you on that one! If you see something interesting in our backlog of issues, please feel free to drop a comment on it to discuss and we can figure something out before you get started on an issue 😄