Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: 0.7 CSS changes, details page updates #2606

Merged
merged 9 commits into from
Nov 1, 2021
Merged

ui: 0.7 CSS changes, details page updates #2606

merged 9 commits into from
Nov 1, 2021

Conversation

sabrinako
Copy link
Contributor

@sabrinako sabrinako commented Oct 27, 2021 •
edited
Loading

Changes

  • Removed app cards on application overview screen
  • Changed border to bottom of Section component instead of underlining the title
  • Changed order of tabs on application overview screen to match new designs
  • Added PanelHeader component for details page headers (to not interfere with styling of the existing PageHeader component)
  • Added a isExpandable param to the Section component to remove collapsibility of a section
  • Updated headings on artifact list pages (h3 -> h2) to comply with a11y warnings (styling maintained)

Related Changes Not Addressed in this PR

  • Remove unused components (PR is long enough and these removals won't affect end user)
    • Related styling can be removed as well

Screenshots

Application Overview Screen Before

Screen Shot 2021-10-28 at 3 31 51 PM

Application Overview Screen After

Screen Shot 2021-10-28 at 3 26 18 PM

Deployment Details Page Before

Screen Shot 2021-10-28 at 3 32 25 PM

Deployment Details Page After

Screen Shot 2021-10-29 at 3 46 42 PM

Build Details Page Before

Screen Shot 2021-10-28 at 3 33 48 PM

Build Details Page After

Screen Shot 2021-10-29 at 3 47 42 PM

Release Details Page Before

Screen Shot 2021-10-28 at 3 34 38 PM

Release Details Page After

Screen Shot 2021-10-28 at 3 26 44 PM

How to Test

  1. Pull down this branch (git checkout ui/0.7-small-changes)
  2. Start up your dev environment with either:
  3. Mirage data ember serve or yarn start
  4. Local server (see: here) then ember serve local
  5. Click around to the application overview page and the details pages for builds, deployments, and releases

@github-actions github-actions bot added the ui label Oct 27, 2021
@sabrinako sabrinako changed the title UI/0.7 small changes WIP: UI/0.7 CSS changes, details page updates Oct 27, 2021
@sabrinako sabrinako linked an issue Oct 28, 2021 that may be closed by this pull request
ui: Update artifact details page to new design #2613
Closed
ui: fixed StatusReportMetaTable logic
7c652c0 
- rerun health check button works again
- "Currently unavailable" only renders when there is nothing there
- {{yield}} rows will render alongside rows hardcoded in the table comp
@sabrinako sabrinako force-pushed the ui/0.7-small-changes branch from b1eb428 to 3e73518 Compare October 29, 2021 19:41
@sabrinako sabrinako force-pushed the ui/0.7-small-changes branch from 3e73518 to b3d8982 Compare October 29, 2021 19:45
@sabrinako sabrinako force-pushed the ui/0.7-small-changes branch from b3d8982 to e0a59a0 Compare October 29, 2021 20:06
@sabrinako sabrinako requested a review from a team October 29, 2021 20:20
@sabrinako sabrinako marked this pull request as ready for review October 29, 2021 20:20
@sabrinako sabrinako changed the title WIP: UI/0.7 CSS changes, details page updates ui: 0.7 CSS changes, details page updates Oct 29, 2021
jgwhite
jgwhite approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@jgwhite jgwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great step forward to me. I’ve left a few minuscule nitpicks, but overall very much approve.

ui/app/components/panel-header.hbs Outdated Show resolved Hide resolved
ui/app/components/section.ts Outdated Show resolved Hide resolved
ui/app/components/status-report-meta-table/index.hbs Outdated Show resolved Hide resolved
ui/app/components/status-report-meta-table/index.hbs Outdated Show resolved Hide resolved
ui/app/components/status-report-meta-table/index.hbs Outdated Show resolved Hide resolved
ui/app/templates/workspace/projects/project/app/deployment.hbs Outdated Show resolved Hide resolved
ui/app/templates/workspace/projects/project/app/release.hbs Outdated Show resolved Hide resolved
ui/tests/integration/components/panel-header-test.ts Outdated Show resolved Hide resolved
@jgwhite jgwhite added this to the 0.7.0 milestone Nov 1, 2021
@sabrinako sabrinako force-pushed the ui/0.7-small-changes branch from 20a8cc9 to 4132b19 Compare November 1, 2021 19:18
@sabrinako sabrinako force-pushed the ui/0.7-small-changes branch from 4132b19 to 62f296c Compare November 1, 2021 19:34
@sabrinako sabrinako merged commit 8a29aa2 into main Nov 1, 2021
@sabrinako sabrinako deleted the ui/0.7-small-changes branch November 1, 2021 19:48
@sabrinako sabrinako mentioned this pull request Nov 1, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgwhite jgwhite jgwhite approved these changes

Assignees

@sabrinako sabrinako

Labels
ui
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

ui: Update artifact details page to new design
2 participants
@sabrinako @jgwhite