Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

cli: release cmd tuneups #2426

Merged
merged 6 commits into from
Oct 6, 2021
Merged

cli: release cmd tuneups #2426

merged 6 commits into from
Oct 6, 2021

Conversation

krantzinator
Copy link
Contributor

@krantzinator krantzinator commented Oct 5, 2021 •
edited
Loading

Things done:

  • removed the [id] arg that isn't used
  • amend the deployment ID returned in the CLI message to match the type of ID we use in deployment list
  • fix the logic on whether or not a 🚀 shows in release list

@krantzinator krantzinator added the pr/no-changelog No automatic changelog entry required for this pull request label Oct 5, 2021
@krantzinator krantzinator added this to the 0.6.0 milestone Oct 5, 2021
@krantzinator krantzinator removed the pr/no-changelog No automatic changelog entry required for this pull request label Oct 5, 2021
@krantzinator krantzinator requested a review from a team October 5, 2021 20:53
briancain
briancain approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

internal/cli/release_create.go Outdated Show resolved Hide resolved
@krantzinator krantzinator merged commit 00025df into main Oct 6, 2021
@krantzinator krantzinator deleted the b/cli/release-cmd-tuneups branch October 6, 2021 14:20
@krantzinator krantzinator linked an issue Oct 6, 2021 that may be closed by this pull request
cli: release cmd doesn't release the specified deployment #2425
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

Assignees
No one assigned
Labels
core website
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

cli: release cmd doesn't release the specified deployment
2 participants
@krantzinator @briancain