This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix a few minor kubernetes papercuts #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. This scales the wait time back so that bad deploys fail much faster. Previously we had it hardcoded to 10 minutes, now it's dynamic. 2. When a deployment fails, print out non Info events from the pods to help the user diagonise what happened. 3. Provide some small grace period on pod cleanup to allow for the potential of debugging the failed pods directly. 4. Handle not being able to search for metric pods 5. Handle destroying an old deployment that didn't have autoscaling defined yet. 6. Setup the kubernetes service with the workspace name if the workspace is not the default workspace
evanphx
added
pr/no-changelog
mitchellh
reviewed
Oct 1, 2021
| ui terminal.UI, | ||
| target *Deployment, | ||
| dcr *component.DeclaredResourcesResp, | ||
| ) (*Release, error) { | ||
| var result Release | ||
| result.ServiceName = src.App | ||
|
|
||
| if job.Workspace == "default" { |
There was a problem hiding this comment.
I think we should throw this in the labels too for the label selector.
There was a problem hiding this comment.
Not sure what ya mean....
briancain
suggested changes
Oct 1, 2021
| dep, err := dc.Get(ctx, result.Name, metav1.GetOptions{}) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| if time.Since(lastStatus) > 10*time.Second { | ||
| step.Update(fmt.Sprintf( | ||
| "Waiting on deployment to become available: %d/%d/%d", | ||
| "Waiting on deployment to become available: requested=%d running=%d ready=%d", |
There was a problem hiding this comment.
I noticed this change in your demo and I like it! 👍🏻 ✨
| if ev.Type == "Normal" { | ||
| continue | ||
| } | ||
| ui.Output(" %s: %s (%s)", ev.Type, ev.Message, ev.Reason) |
There was a problem hiding this comment.
I also noticed this change in your demo, excited for this! 😄
Co-authored-by: Brian Cain <[email protected]>
briancain
approved these changes
Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had it hardcoded to 10 minutes, now it's dynamic.
help the user diagonise what happened.
potential of debugging the failed pods directly.
defined yet.
is not the default workspace